Jacob Walls comments

Results 451 comments of


                                            Jacob Walls

Use `.get` method instead of `in` operator to get value from inference cache safely

Thanks, free free to reopen if you can provide a reproducer. Cheers.

False positive: possibly-used-before-assignment doesn't understand and-ed contions

@Pierre-Sassoulas is it too confusing that we made a limited exception for the last if consisting of the "exact same test"? Should we just always emit a message?

False positive: possibly-used-before-assignment doesn't understand and-ed contions

> Sorry I did not remember about this. I suppose undertanding that if an arbitrarily complex conditional is true another arbitrarily complex conditional is also true might be useful in...

False positive: possibly-used-before-assignment doesn't understand and-ed contions

Okay, right. I guess we could check for the absence of any other assignments to `a` in between `if a` and `if a and ...` before deciding that `if a...

Resolve `used-before-assignment` false negative when a function is defined under `TYPE_CHECKING`

Thanks so much @zenlyj, is this ready for review?

Resolve `used-before-assignment` false negative when a function is defined under `TYPE_CHECKING`

I'll handle the Home Assistant false positive in another PR.

Resolve `used-before-assignment` false negative when a function is defined under `TYPE_CHECKING`

> we should probably raise a message here? Good catch, I'm fine with opening a new issue for it. I think it should be real UBA, not "possibly".

Inference of JoinedStr is inconsistent

Thanks for catching that we're not catching exceptions thrown by `_infer()` inside `infer_from_values()`. But re: the inconsistencies between raising and returning a partial string seem like something we should resolve...

`PathFinder.find_spec()` can raise bare `KeyError` when `path=None`

I see from #89754 that this is invalid/poor usage if you know in advance that there's a resource under `a/`, but probably ~`None` is the better outcome?~ the correct outcome...

`PathFinder.find_spec()` can raise bare `KeyError` when `path=None`

Thanks for taking a look @serhiy-storchaka. The result I get with #98100 is the result when the `a/b.py` file is not present, namely the path to the `/b` directory. What...