Jacob Walls

Results 438 comments of Jacob Walls

>As in, we're mimicking what locals() does? Hard to say! Docstring just says: > """A map of the name of a local variable to the node defining it.""" From CPython...

> But I have no idea how to deal with nonlocals like that. It seems I could only go through the function's body to find the Nonlocal statements. That sounds...

> So will it be a good idea to include both global x1 and nonlocal x2 into f2.locals, and add an extra property to indicate whether they are global or...

I guess I wouldn't expect `x = 2` in f1's locals.

And a housekeeping note: you can update the PR title to say "Fixed ..." since we'll be closing the ticket.

I'm not sure how we would do that. I don't think we need to worry about it at this juncture.

> What should be done about the failing check @jacobtylerwalls ? From the last commit that passed all checks, all that's been modified is the search.txt file and that's not...