zzak
zzak
We have to update the initial steps for this to run
Will look into the test failures later
@jkowens Thanks for taking a look. My reason for starting with Rack 2 support was to estimate the effort, that's all. If it seems like too painful to fix then...
I've taken a stab at making a reproducible patch for Resque here: https://github.com/resque/resque/pull/1906 Someone should be able to copy it for the other gems.
@albus522 Each gem should just run their tests against Rails main so we can pick up breaking changes as early as possible. I've trimmed down the number of tests included...
How about making it a gem? Instead of fallback, we can warn that they need to require the gem in the future then remove it.
> is clearly not okay You're 100% right, I was wondering how to update the messaging but meant to ask that in review. Sorry for not clarifying. How does bd7fd1a...
Opened a PR to fix the failing test in Rails, it's caused by the name change in 4d80a26. I don't think there's any action needed to be taken by Sidekiq.
@seuros This can be closed. The integration test failure is fixed by updating sidekiq gem.
I've tested this branch against my app and it works, but I needed to make this small change: ``` commit cb31d3757f07743713154f5afd748b69d412129b (HEAD -> upstream-patched-321, origin/upstream-patched-321) Author: zzak Date: Thu Jun...