zzak
zzak
@AlexisChavez97 Thanks for your patience, please give me a little more time to debug the tests myself. :bow:
Rebased and pushed df8e585 which should fix the other tests, couple quick notes: * `rails "generate", "whatever"` does not give us the same result as simply `Dir.chdir(app_path) { system("bin/rails generate...
Just waiting on feedback, would you mind [squashing](https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#squashing-commits) while we wait?
@rossme Yeah if you want to just open a PR first next time, that is preferred. Using issues to ask "is this a bug?" is fine but if you're already...
Was the linter failing before this?
> The linter failed without the modifications to the style Where did the actual failures occur? Because I don't see them. Was this in your own fork?
Ahh, ok sorry. I'm still getting over this virus so apologies for my dimness. The problem here is that the code samples in the guide don't pass the omakase rubocop...
@joelyles Sorry to be a pain, would you mind [squashing your commits](https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#squashing-commits)?
@joelyles It's ok, I just merged it by hand in 7af392f227e2bf75e0c1504aa8eedd7b3c6102af. Thanks for your patch! I think GitHub gets confused sometimes, sorry about that. :bow:
I think this is also related to #53059.