buildkite-config icon indicating copy to clipboard operation
buildkite-config copied to clipboard

Remove approval block to run tests, lint, and annotations

Open zzak opened this issue 1 year ago • 2 comments

These steps are designed so any code executed from the workspace happens inside an unprivileged docker container.

We would get faster feedback on PRs if these run instantly.

zzak avatar Dec 02 '24 04:12 zzak

Moving it is fine (I'd wondered why the lint checks were placed before it), but removing "this is an important security gate" with "avoid spending extra build resources" [do we really have enough PRs here for that to be important?] is clearly not okay.

matthewd avatar Dec 02 '24 08:12 matthewd

is clearly not okay

You're 100% right, I was wondering how to update the messaging but meant to ask that in review. Sorry for not clarifying. How does bd7fd1a look?

avoid spending extra build resources

My original thought was not cost for BK, but that we had (have?) a max 100 agents available and one build can take a significant amount of them, so triggering a bunch of test CI runs will quickly result in many pending jobs. That is less common, given how few PRs we get but wanted to call that out in the review.

zzak avatar Dec 02 '24 21:12 zzak