zzak
zzak
Another side of this is other than event reporting, this feature can also be configured to raise an exception -- but I assume that is not intended for production; therefor...
@adrianna-chang-shopify Thanks for taking a look! :bow: > I'm happy to push up some additional commits to your branch if you're okay with it? I'd love if folks could hop...
Good point here: https://github.com/rails/rails/issues/50452#issuecomment-3573133525 > I have read and believe I understand the conversation in https://github.com/rails/rails/pull/55334 and while that seems helpful for gathering telemetry, there's a documentation gap on how...
@OughtPuts Thanks for all the suggestions and your review :bow: I will make another pass at this to clean things up.
@adrianna-chang-shopify Thanks for your commit and review! > Testing I thought about this, like how we use `event_matcher` to test the reporter itself, but that API is private: https://github.com/rails/rails/blob/main/activesupport/lib/active_support/event_reporter/test_helper.rb Should...
I think this makes sense, should we deprecate the flag too? Then the name should be `deprecated_...` or something :thinking:
I think making deprecated_whatever default to false in 8.2 and otherwise true for the old behavior makes sense, shorter name looks better IMO
It's just a flake, I've rerun the failed job. Let's wait for more feedback on this, thanks for your work! :bow:
@intrip This seems similar to #42494, wdyt?
This can be closed