zzak

Results 331 comments of zzak

> Sorry, I missed adding the validation. I took another look at the wording and implementation and updated this here https://github.com/rails/rails/commit/024487d3c8d4e55a166741d140ea74e0718343d1. Sorry for the late reply, I think this is...

I was under the impression that buildkite/ci was using a tty and therefor these tests were running. @yahonda can probably verify that.

I'm unable to reproduce it locally: ``` bin/test -v test/engine/commands_test.rb:62 Run options: -v --seed 6467 # Running: Rails::Engine::CommandsTest#test_server_command_broadcast_logs = 2.14 s = . Finished in 2.145408s, 0.4661 runs/s, 2.7967 assertions/s....

I'm on linux, but I remember there being some differences in the native threads they used. Worst case, we can try to spike on a macos runner on GH actions...

I wonder if just adding a sleep after spawning the process also solves it for you, like the process may have output "Listening on..." but it's not accepting connections yet...

@davidstosik Thanks for your detailed investigation. I was able to reproduce the issue using a macos runner on github actions, and indeed your fix to use a thread to make...

Thanks for your patch! From the AWS docs, for reference: > When you upload an object, Amazon S3 uses the encryption key that you provide to apply AES-256 encryption to...

@ransombriggs Sorry that we missed this, it was a big (and well worth) refactor, and in the future I hope we can make API changes easier to review on a...

Yeah I don't think we should change the behavior of the flag, maybe.

It looks like your base branch is outdated back to May 30, 2024. Would you mind rebasing to clear up the build failures?