zzak

Just waiting for feedback, but there was a much larger PR to add multi-db support which I think conflicts with this

It works if you use `database_tasks: false` in your database config: ```diff diff --git a/config/database.yml b/config/database.yml index 693252b..69de347 100644 --- a/config/database.yml +++ b/config/database.yml @@ -19,6 +19,7 @@ development: test:

It took me a bit, but I was able to produce this error in the test with a service account using IAM: ``` Error: ActiveStorage::Service::GCSServiceTest#test_direct_upload_with_IAM_signing: Google::Apis::AuthorizationError: Unauthorized google-apis-core-0.15.1/lib/google/apis/core/http_command.rb:235:in 'Google::Apis::Core::HttpCommand#check_status' google-apis-core-0.15.1/lib/google/apis/core/api_command.rb:137:in...

@jmalcic Thanks, no I could produce the error in both those tests and fixed with this patch.

Could you [squash your commits](https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#squashing-commits) please?

Can confirm it's still there: ``` ls -aslh main/guides/output/ | grep html$ 72K -rw-r--r-- 1 rails rails 70K Dec 3 15:42 2_2_release_notes.html 104K -rw-r--r-- 1 rails rails 102K Dec 3...

@harsh183 The generator is defined here: https://github.com/rails/rails/blob/main/guides/rails_guides/generator.rb#L18 Maybe it can be made to clean the output directory instead. I don't think there's any files in that directory we expect to...

Could you add a test and/or reproduction case? Was there a ticket associated with this PR?

Cool just checking, I saw this and thought neat but there was no bug associated or other context, so wasn't sure if it was ready for review or not. :pray:

> what version should I put in the deprecation message :), if this goes live in 8.2, then 9? Judging by the other deprecations, we should use 8.2: ``` activesupport/lib/active_support.rb:137:...