Zizhou Wang
Zizhou Wang
Please get breaking change review approved first and then come back for ARM review
Is there a API version change in this PR? Can you fix the change log?
> "$ref": "../../common/v1/definitions.json#/parameters/ResourceGroupNameParameter" Try use v3 when possible --- Refers to: specification/automation/resource-manager/Microsoft.Automation/stable/2022-08-08/python3package.json:56 in b311391. [](commit_id = b311391ed2b0ea90457e1593e4ff80b9516816a9, deletion_comment = False)
> "modelAsString": false Any particular reason why this is false, it will be much easier to add if this is true [https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html?q=modelAsString#oapi015-avoid-modelling-a-property-as-string-type-when-it-should-be-an-enums](https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html?q=modelAsString#oapi015-avoid-modelling-a-property-as-string-type-when-it-should-be-an-enums) --- Refers to: specification/automation/resource-manager/Microsoft.Automation/stable/2022-08-08/python3package.json:636 in b311391. [](commit_id =...
> See https://github.com/Azure/azure-rest-api-specs-pr/blob/main/specification/common-types/resource-management/v3/types.json#L638 Will not block this PR on this, signing off, and you can take a look at these v3
I see a lot of failures in the run, is this ready for review? Please remove "ARMChangesRequested" tag once it's ready.
> "$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/SubscriptionIdParameter" Use v3 common-types when possible, same for the rest of the PR --- Refers to: specification/cosmos-db/resource-manager/Microsoft.DocumentDB/preview/2022-08-01-preview/cosmos-db.json:2498 in a46d6bc. [](commit_id = a46d6bc774d94c7dcf9103c4d41a6937ddec9eec, deletion_comment = False)
Will put this into "ARMChangesRequested", once you fixed the issue with SDK team, please remove "ARMChangesRequested" tag again and we can come back to approve this.
Is there a new API version, or can you fix the changelog on what this PR is about?
There's another PR that is adding this to preview, this is going to be added for both preview and stable at same time?