azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Dev desktopvirtualization microsoft.desktop virtualization 2022 08 10

Open mateialexandru opened this issue 3 years ago • 9 comments

Changelog

  1. What's the purpose of the update?
    • [x] Other: adding a missing query parameter named force to the specification
  2. When are you targeting to deploy the new service/feature to public regions?
    • Week of August 15 2022 -> onward
  3. When do you expect to publish the swagger?
    • 12 August 2022
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • [ ] SDK of .NET (need service team to ensure code readiness)
    • [ ] SDK of Python
    • [ ] SDK of Java
    • [ ] SDK of Js
    • [ ] SDK of Go
    • [x] PowerShell
    • [ ] CLI
    • [ ] Terraform
    • [ ] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [x] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • [x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • [ ] Removing API(s) in a stable version
  • [ ] Removing properties in a stable version
  • [ ] Removing API version(s) in a stable version
  • [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
  • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

mateialexandru avatar Aug 10 '22 21:08 mateialexandru

Hi, @mateialexandru Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    openapi-workflow-bot[bot] avatar Aug 10 '22 21:08 openapi-workflow-bot[bot]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 127 Warnings warning [Detail]
    compared swaggers (via Oad v0.9.7)] new version base version
    desktopvirtualization.json 2022-08-10(909299d) 2021-07-12(main)
    desktopvirtualization.json 2022-08-10(909299d) 2022-04-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Only 28 items are listed, please refer to log for more details.

    Rule Message
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/scalingPlans/{scalingPlanName}/pooledSchedules/{scalingPlanScheduleName}' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L560:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/scalingPlans/{scalingPlanName}/pooledSchedules' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L758:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/privateEndpointConnections' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L2710:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L2756:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/hostPools/{hostPoolName}/privateLinkResources' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L2899:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/workspaces/{workspaceName}/privateEndpointConnections' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L2945:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/workspaces/{workspaceName}/privateEndpointConnections/{privateEndpointConnectionName}' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L2991:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DesktopVirtualization/workspaces/{workspaceName}/privateLinkResources' removed or restructured?
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3134:5
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AgentUpdateProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'AgentUpdatePatchProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ScalingPlanPooledSchedulePatch' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ScalingPlanPooledSchedule' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ScalingPlanPooledScheduleProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Time' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateEndpointConnectionProvisioningState' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateEndpointServiceConnectionStatus' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateLinkServiceConnectionState' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateEndpoint' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateEndpointConnectionProperties' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'PrivateEndpointConnection' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'systemData' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2456:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L3181:3
    :warning: 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ScalingPlanScheduleNameParameter' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4757:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L6051:3
    :warning: 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'PrivateEndpointConnectionName' removed or renamed?
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4757:3
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L6051:3
    :warning: 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4471:9
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L5479:9
    :warning: 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4502:9
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L5509:9
    :warning: 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4519:9
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L5525:9
    :warning: 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4575:9
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L5580:9
    :warning: 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3750:9
    Old: Microsoft.DesktopVirtualization/preview/2022-04-01-preview/desktopvirtualization.json#L4738:9
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️❌LintDiff: 13 Errors, 28 Warnings failed [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-08 package-2022-08(909299d) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Only 28 items are listed, please refer to log for more details.

    Rule Message Related RPC [For API reviewers]
    ❌ R4010 - RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L46
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2892
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2910
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3028
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3057
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3510
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3605
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3750
    ❌ R4013 - IntegerTypeMustHaveFormat The integer type does not have a format, please add it.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3943
    ❌ R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2457
    ❌ R4037 - MissingTypeObject The schema 'ResourceProviderOperationList' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2478
    ❌ R4037 - MissingTypeObject The schema 'ResourceProviderOperation' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2491
    ❌ R4037 - MissingTypeObject The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2499
    :warning: R2029 - PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L30
    :warning: R2029 - PageableOperation Based on the response model schema, operation 'Desktops_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L1257
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'Workspaces_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L57
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'Workspaces_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L97
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'Workspaces_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L192
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'ScalingPlans_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L324
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'ScalingPlans_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L364
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'ScalingPlans_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L459
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'ApplicationGroups_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L591
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'ApplicationGroups_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L631
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'ApplicationGroups_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L726
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'Applications_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L917
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'Applications_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L960
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'Applications_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L1061
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'Desktops_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L1160


    The following errors/warnings exist before current PR submission:

    Only 28 items are listed, please refer to log for more details.

    Rule Message
    ❌ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4458
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2482
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2542
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3263
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3281
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3839
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3858
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4080
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4431
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4438
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4693
    ❌ R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4700
    :warning: R1003 - ListInOperationName Since operation 'MsixImagesExpand' response has model definition 'x-ms-pageable', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2113
    :warning: R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2524
    :warning: R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'expandmsiximage' in:'MsixImages_Expand'. Consider updating the operationId
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2113
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'msixPackages' with immediate parent 'HostPool', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3204
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'applications' with immediate parent 'ApplicationGroup', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3406
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'desktops' with immediate parent 'ApplicationGroup', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3633
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'sessionHosts' with immediate parent 'HostPool', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L3913
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'userSessions' with immediate parent 'SessionHost', must have a list by immediate parent operation.
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L4274
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L1419
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L1738
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L1797
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: force
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2240
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2520
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2610
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: cloudPcResource
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2743
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: validationEnvironment
    Location: Microsoft.DesktopVirtualization/stable/2022-08-10/desktopvirtualization.json#L2914
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.DesktopVirtualization' for api version '2022-08-10'. The supported api-versions are '2019-01-23-preview,
    2019-09-24-preview,
    2019-12-10-preview,
    2020-09-21-preview,
    2020-10-19-preview,
    2020-11-02-preview,
    2020-11-10-preview,
    2021-01-14-preview,
    2021-02-01-preview,
    2021-03-09-preview,
    2021-04-01-preview,
    2021-05-13-preview,
    2021-08-04-preview,
    2021-09-03-preview,
    2021-09-17-privatepreview,
    2022-01-12-privatepreview,
    2022-02-10-preview,
    2022-04-01-preview,
    2022-06-03-privatepreview,
    2022-07-05-preview,
    2022-08-09-privatepreview,
    2021-07-12'."
    ️❌~[Staging] ServiceAPIReadinessTest: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ ASSERTION_ERROR "ResourceType 'workspaces' should be deployed in 'West Central US' on apiVersion '2022-08-10'.: expected [ Array(12) ] to satisfy [Function]"
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/909299dc76202ea7f6247b1c7007073c2ad10c48/specification/desktopvirtualization/resource-manager/readme.md#tag-package-2022-08">desktopvirtualization/resource-manager/readme.md#package-2022-08
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    openapi-pipeline-app[bot] avatar Aug 10 '22 21:08 openapi-pipeline-app[bot]

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-desktopvirtualization - 1.0.0b1
    -	Parameter time_zone of model ScalingPlan is now required
+	Model Application no longer has parameter system_data
+	Model ApplicationGroup no longer has parameter system_data
+	Model Desktop no longer has parameter system_data
+	Model HostPool no longer has parameter public_network_access
+	Model HostPool no longer has parameter system_data
+	Model HostPoolPatch no longer has parameter public_network_access
+	Model MSIXPackage no longer has parameter system_data
+	Model ResourceProviderOperationList no longer has parameter next_link
+	Model ScalingPlan no longer has parameter system_data
+	Model SessionHost no longer has parameter system_data
+	Model UserSession no longer has parameter system_data
+	Model Workspace no longer has parameter public_network_access
+	Model Workspace no longer has parameter system_data
+	Model WorkspacePatch no longer has parameter public_network_access
+	Removed operation group PrivateEndpointConnectionsOperations
+	Removed operation group PrivateLinkResourcesOperations

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from f70969e5f13892279c0ef236b177a2b22f137bbc. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.DesktopVirtualization [View full logs]  [Preview SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from f70969e5f13892279c0ef236b177a2b22f137bbc. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-desktopvirtualization [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model ScalingPlanPatch has a new parameter host_pool_type
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model Application no longer has parameter system_data
info	[Changelog]   - Model ApplicationGroup no longer has parameter system_data
info	[Changelog]   - Model Desktop no longer has parameter system_data
info	[Changelog]   - Model HostPool no longer has parameter public_network_access
info	[Changelog]   - Model HostPool no longer has parameter system_data
info	[Changelog]   - Model HostPoolPatch no longer has parameter public_network_access
info	[Changelog]   - Model MSIXPackage no longer has parameter system_data
info	[Changelog]   - Model ResourceProviderOperationList no longer has parameter next_link
info	[Changelog]   - Model ScalingPlan no longer has parameter system_data
info	[Changelog]   - Model SessionHost no longer has parameter system_data
info	[Changelog]   - Model UserSession no longer has parameter system_data
info	[Changelog]   - Model Workspace no longer has parameter public_network_access
info	[Changelog]   - Model Workspace no longer has parameter system_data
info	[Changelog]   - Model WorkspacePatch no longer has parameter public_network_access
info	[Changelog]   - Removed operation group PrivateEndpointConnectionsOperations
info	[Changelog]   - Removed operation group PrivateLinkResourcesOperations
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from f70969e5f13892279c0ef236b177a2b22f137bbc. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/desktopvirtualization/armdesktopvirtualization [View full logs]  [Preview SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `Force` in struct `SessionHostsClientUpdateOptions`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from f70969e5f13892279c0ef236b177a2b22f137bbc. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-desktopvirtualization [View full logs]  [Preview SDK Changes] 
      info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from f70969e5f13892279c0ef236b177a2b22f137bbc. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️desktopvirtualization [View full logs]  [Preview Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from f70969e5f13892279c0ef236b177a2b22f137bbc. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.DesktopVirtualizationApi [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    openapi-pipeline-app[bot] avatar Aug 10 '22 21:08 openapi-pipeline-app[bot]

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/desktopvirtualization/armdesktopvirtualization https://apiview.dev/Assemblies/Review/37c3f28fd2994e53810bbe05756e62b2
    Python track2_azure-mgmt-desktopvirtualization https://apiview.dev/Assemblies/Review/2480c058b49b4970915dd3568c0c08f8
    .Net Azure.ResourceManager.DesktopVirtualization There is no API change compared with the previous version
    Java azure-resourcemanager-desktopvirtualization https://apiview.dev/Assemblies/Review/027467162ed44b2086ffef03f7585903
    JavaScript @azure/arm-desktopvirtualization https://apiview.dev/Assemblies/Review/65554fd5953c48e698c50c8cb7313991

    openapi-pipeline-app[bot] avatar Aug 10 '22 21:08 openapi-pipeline-app[bot]

    Hi @mateialexandru, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    openapi-workflow-bot[bot] avatar Aug 10 '22 22:08 openapi-workflow-bot[bot]

    /azp run

    mateialexandru avatar Aug 10 '22 22:08 mateialexandru

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Aug 10 '22 22:08 azure-pipelines[bot]

    Hi, @mateialexandru your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    openapi-workflow-bot[bot] avatar Aug 10 '22 22:08 openapi-workflow-bot[bot]

    Hi @mateialexandru, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    openapi-workflow-bot[bot] avatar Aug 20 '22 05:08 openapi-workflow-bot[bot]

    Please get breaking change review approved first and then come back for ARM review

    zizw123 avatar Aug 24 '22 20:08 zizw123

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    openapi-workflow-bot[bot] avatar Aug 24 '22 20:08 openapi-workflow-bot[bot]

    /azp run

    mateialexandru avatar Aug 24 '22 22:08 mateialexandru

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Aug 24 '22 22:08 azure-pipelines[bot]

    Hi, @mateialexandru. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Sep 11 '22 16:09 ghost

    Hi, @mateialexandru. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar Sep 26 '22 05:09 ghost