Zizhou Wang

Results 43 comments of Zizhou Wang

Please fix all the issues and address all the labels, after that add back WaitForARMFeedback for ARM to review

Is anything being copied from previous API version? Or is everything new in this API version. If anything is copied over, the first commit needs to be the previous api...

> }, Use 201/200 + provisioning state instead of 202, see : [https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#creatingupdating-using-put](https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#creatingupdating-using-put) --- Refers to: specification/healthcareapis/resource-manager/Microsoft.HealthcareApis/preview/2022-10-01-preview/healthcare-apis.json:2347 in b3f0ba4. [](commit_id = b3f0ba445450b159721ba80b6bfb884c1d5c5ae6, deletion_comment = False)

> }, Is 200 needed here? See [https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#updating-using-patch](https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#updating-using-patch) --- Refers to: specification/healthcareapis/resource-manager/Microsoft.HealthcareApis/preview/2022-10-01-preview/healthcare-apis.json:2406 in b3f0ba4. [](commit_id = b3f0ba445450b159721ba80b6bfb884c1d5c5ae6, deletion_comment = False)

> Hi! This swagger was already approved in the Private repo. Please see the following link for the review: [Azure/azure-rest-api-specs-pr#9094](https://github.com/Azure/azure-rest-api-specs-pr/pull/9094) signed off base on this

> Hi, @ittayo, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push...

This PR is labeled with breaking change, please get it reviewed first

> "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Media/mediaservices/{accountName}/liveEvents/{liveEventName}/trackIngestHeartbeats": { Like rkmanda mentioned, please check the lintdiff for this --- Refers to: specification/mediaservices/resource-manager/Microsoft.Media/Streaming/stable/2022-11-01/streamingservice.json:593 in aef67ad. [](commit_id = aef67ad340dda57cd4c084983cb71849f8bb6ea0, deletion_comment = False)

> "value": { Check the errors in Swagger LintDiff, rests look good --- Refers to: specification/peering/resource-manager/Microsoft.Peering/stable/2022-10-01/peering.json:4204 in 71a260a. [](commit_id = 71a260a58e79a7d4126706e0d0cf0ea6417f7528, deletion_comment = False)