Zizhou Wang

Results 43 comments of Zizhou Wang

> NewApiVersionRequired reason: A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response...

> > > > @zizw123 this feature is not released to customers yet. It is still under the feature flag. This change was already approved in the previous versions (ref...

Please check the lint error in https://github.com/Azure/azure-rest-api-specs/pull/21080/checks?check_run_id=11211115269

> Hi, @snehachebrolu23, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push...

> "201": { Should use 202 for async PATCH, and also use location header, see [https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#updating-using-patch](https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/async-api-reference.md#updating-using-patch) #Resolved --- Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:268 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)

> "201": { Same for this #Resolved --- Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:268 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)

> @visingla-ms, we are trying to meet a deadline to get this PR published, is there any way you can take a look at this soon and provide feedback? It...

> > @talco773 I left the following comment. Kindly help confirm it. Thanks. [#24090 (comment)](https://github.com/Azure/azure-rest-api-specs/pull/24090#discussion_r1223788132) > > I replied the relevant comment Please see the latest respond on the comment,...

> Hi, @jessicl-ms, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push...

Approving the suppression and the PR based on our discussion and https://github.com/Azure/azure-rest-api-specs/pull/22777