Yacin Tmimi

Results 716 comments of Yacin Tmimi

> the algorithm does mention spaces relative to underscores (noted below), but i presume that's the type of thing you were alluding to a follow up PR in the description?...

Thanks for working on the docs! I'm guessing cargo didn't automatically install the toolchain and components listed in the `rust-toolchain` file when you tried to build? Whenever we bump the...

@goetz-markgraf Thanks for making some changes. I actually preferred your first draft better than what you changed it to. Would you be able to take another go at this and...

> The first draft show a way to install toolchain and components, but for rustfmt this way is wrong, as I have learnd. Since there is a rust-toolchain-file, one should...

Macro formatting is tough. It might be the case that `id -u` is getting parsed as a binary expression, and that's why it's getting formatted as `id - u`. If...

You could probably add `#![rustfmt::skip]` to the files you want rustfmt to ignore

I've been thinking about what the best return type is for `build_rustfmt_from_src`, and this is what I've come up with. Happy to change the name, but ultimately we need to...

> I was wondering if the error for `run` be an `IO` error or do you think its better to have a custom error for `RustfmtRunner`? I was thinking maybe...

That's likely the issue. Is it an issue to use `lazy_static!` instead of `lazy_static::lazy_static!` in your code?

Appreciate you taking the time to file the issue, and I'm glad to hear that there isn't any restriction that requires you to use `lazy_static::lazy_static!` instead of `lazy_static!`.