Yacin Tmimi

Results 716 comments of Yacin Tmimi

lazy_static was removed in #6154

Thanks for the report! There's currently a proposal to add an option to rustfmt to always add `0` to the end of float literals (#5834). We've also had similar issues...

I've also realized that we have a [spaces_around_ranges](https://github.com/rust-lang/rustfmt/blob/master/Configurations.md#spaces_around_ranges) option that could also be used to mitigate this issue.

Hey all 👋🏼, just wanted to chime into the discussion with a little bit of info. > Is there a reason why RUST put's it's open bracket on the same...

> Ok so it is the opinion of some group of people Yes and no. Style decisions are made after coming to a consensus. Anyone is free to open PRs...

I'd like to land #5611 before taking a look at these changes. I'm not 100% sure if that will impact what you're trying to do here but I wanted to...

@rscprof Can you take a look at the failures when you have a chance. Also, the rustfmt team strongly discourages merge commits. When you have a moment can you rebase...

@rscprof I'm still seeing the [Merge branch 'master' into issue-6013](https://github.com/rust-lang/rustfmt/pull/6024/commits/ba832a92240fbee7fe6b65f7d3272cc6492088b7) commit in the history. Can you please update the git history to remove that merge commit.

@Jules-Bertholet when you have a moment can you remove the fix for https://github.com/rust-lang/rustfmt/issues/6069 from this PR and open a separate PR that independently addresses that issue.

> The test for the nfc_normalize_idents relies on the https://github.com/rust-lang/rustfmt/issues/6069 fix to pass (it checks that NFC-normalizing idents in trait declaration works, which relies on rustfmt not immediately crashing in...