Yacin Tmimi

Results 716 comments of Yacin Tmimi

Looks like there's still a little work to be done. Formatting with this branch on the snippets you provided removes the where clauses: **input**: ```rust pub const K: Option =...

Just double checking, but where clauses are new to const items now that they can be generic with the `#[feature(generic_const_items)]` , right?

Note to self, unlike the [deprecated type alias syntax](https://doc.rust-lang.org/reference/items/type-aliases.html#:~:text=Where%20clauses%20before%20the%20equals%20sign%20on%20a%20type%20alias%20in%20a%20trait%20impl%20(like%20type%20TypeAlias%3CT%3E%20where%20T%3A%20Foo%20%3D%20Bar%3CT%3E)%20are%20deprecated.%20Where%20clauses%20after%20the%20equals%20sign%20(like%20type%20TypeAlias%3CT%3E%20%3D%20Bar%3CT%3E%20where%20T%3A%20Foo)%20are%20preferred.), it's not possible to place the where clause before the assignment. I put together this small snippet that compiles: ```rust #![feature(generic_const_items)]...

@Frostie314159 I appreciate you opening an issue. However, without a code snippet that can be used to reproduce the issue there's not much anyone can do to help. When you...

TODO: add test case for #5321, which I think this also fixes

That would be very helpful!

No worries. I appreciate that you spent some time trying to narrow it down. Having a link to a repo where I can reproduce the issue is the next best...

All very useful details. Thank you for sharing 😁

Thanks for the PR. Going to mark this one as on hold for now. There was some discussion back in https://github.com/rust-lang/rustfmt/issues/5308, where we were unsure if we should add this...

@x17jiri not at this time. This is something that the team needs to discuss to unblock. [I brought this up for discussion in our last team meeting](https://rust-lang.zulipchat.com/#narrow/stream/357797-t-rustfmt/topic/meeting-2024-02-19/near/422262734), but it hasn't...