rustfmt icon indicating copy to clipboard operation
rustfmt copied to clipboard

fix additional semicolon during changing parentheses style

Open rscprof opened this issue 1 year ago • 5 comments

#6013

Prevent add semicolon when changing parentheses style when using lazy_static. If we see that previous parentheses is round and we use the rule for lazy_static then we set flag about it and after it we simple skip insert semicolon during postprocessing spaces and semicolon.

rscprof avatar Jan 12 '24 07:01 rscprof

Hi @ytmimi, I thought about returning pair, but I thought that it changes functions signatures drastically. I will change it tomorrow in your way.

rscprof avatar Jan 12 '24 16:01 rscprof

@rscprof Can you take a look at the failures when you have a chance. Also, the rustfmt team strongly discourages merge commits. When you have a moment can you rebase these changes instead.

ytmimi avatar Mar 28 '24 12:03 ytmimi

@rscprof Can you take a look at the failures when you have a chance. Also, the rustfmt team strongly discourages merge commits. When you have a moment can you rebase these changes instead.

Hi! I'm going to do all things in a week

rscprof avatar Mar 28 '24 15:03 rscprof

@rscprof I'm still seeing the Merge branch 'master' into issue-6013 commit in the history. Can you please update the git history to remove that merge commit.

ytmimi avatar Mar 28 '24 21:03 ytmimi

@rscprof I'm still seeing the Merge branch 'master' into issue-6013 commit in the history. Can you please update the git history to remove that merge commit.

I made one commit for radically simplifying history

rscprof avatar Mar 29 '24 06:03 rscprof