Yacin Tmimi
Yacin Tmimi
@MarcusGrass thanks for looking into this! I came to the same conclusion regarding chars vs bytes when I looked into this a while ago. I'll follow up when I've had...
Thanks for the report. Yeah, there's something about the OR pattern that's throwing off the alignment. Without the OR pattern things align as you'd expect. **Input**: ```rust fn main() {...
Thanks for your first contribution to rustfmt 🎉. Always great to see new contributors. I won't have a chance to review this today, but I'll be sure to give feedback...
Can we also add the following tests to `tests/rustfmt/main.rs` ```rust #[test] fn ignore_missing_sub_mod_false() { // Ensure that missing submodules cause module not found errors when trying to // resolve submodules...
@tanzaku I know this one has been left on the backlog for a little while. I wanted to check back in and see if you were still interested in working...
Awesome! I wanted to confirm that before jumping back in. When you have a chance, can you rebase on the latest master and fix any merge conflicts.
Thank you, I'll give this one another review later today!
Thanks for pushing those changes. Just wanted to follow up and say that I'm planning to look at this one again later this week!
Thanks for the report! This seems like it's related to #2926. Might even be a duplicate.
@Nemo157 thanks for taking the time to put together a PR. I haven't had a chance to review this yet, but I noticed that a lot of tests needed the...