Yacin Tmimi comments

Results 716 comments of


                                            Yacin Tmimi

Implement space_after_not option

> @ytmimi Sure. Is there something I can help with in the meantime? @x17jiri my last comment was referring to this one being blocked until the team has a chance...

Implement space_after_not option

> Yes, that's what I meant :-) Fantastic! I'll dig through the backlog when I've got a little more free time and tag you in one or two issues that...

Use `semver` to check `required_version` instead of comparing two strings with `!=`

> I didn't find any kind of init command (something like cargo fmt init) to generate the config file, but if we have so, then by default this could add...

`struct_field_align_threshold` doesn't apply when using `..Default::default()`

@theon thanks for the report. For reference, what value are you setting `struct_field_align_threshold` to?

Cannot set granular width configuration settings to 100% if `max_width = 100`

Thanks for the report! Just as a heads up, when filing an issue please try to include a minimum code example that can be used to reproduce the issue along...

Cannot set granular width configuration settings to 100% if `max_width = 100`

@ferdonline Your issue seems unrelated to the original since it's not triggering any warning messages from rustfmt. I'm pretty sure we only set granular width settings as a percentage of...

Cannot set granular width configuration settings to 100% if `max_width = 100`

@ferdonline Please open a new issue so we can discuss it separately. I'm unable to reproduce any warning messages when using `rustfmt 1.6.0-nightly (1c05d50c 2023-10-21)`. I'm running: ``` rustfmt +nightly-2023-10-22...

use std::lazy::SyncLazy instead of lazy_static

Thanks for your first PR! > Can we use the nightly feature `once_cell`? Speaking for myself, I don't see why we couldn't use it. I'm personally not too familiar with...

use std::lazy::SyncLazy instead of lazy_static

That all sounds awesome! Thanks for including those links. I'll be sure to give them a read 😄

use std::lazy::SyncLazy instead of lazy_static

This one is still on hold, but I wanted to mention that the latest tracking issue for this is https://github.com/rust-lang/rust/issues/109736.