Yacin Tmimi
Yacin Tmimi
Thanks for looking into this and for the thoughtful proposal! I feel like multi-threaded rustfmt has popped up in conversation before, but there aren't any links that immediately come to...
#3162 is one of the links I was referencing in https://github.com/rust-lang/rustfmt/issues/6091#issuecomment-1964539411. @MarcusGrass I really appreciate all the thought you've put into this. I also want to be upfront and say...
@sinitcin thanks for the report. We've got a few `SourceAnnotation` panics that are all related, so my initial gut feeling is that this is a duplicate, but I'd need some...
@MarcusGrass thanks for helping out on this one!
Thanks for the PR. Going to put this on hold until the team has had a chance to discuss this change https://github.com/rust-lang/rustfmt/issues/6091#issuecomment-1964539411.
@Sjael could you provide a motivating example for why you'd want to wrap before the `max_width`? I'm a little reluctant about adding this configuration option.
The flakey tests around `max_width` are probably related to #6011. I've got plans to address that one soonish
Definitely not a use case I was thinking of, but it seems reasonable to me. Just a fair warning, I'm trying to go through and review outstanding PRs in the...
Yeah, it's been fun, and I appreciate you applying all the feedback. I know I still owe you a follow up review on the other PR. I'm hoping to get...
> I'm thinking about changing this to being a fn_param_limit where the function declaration breaks to new line based on amount of parameters instead of line length. I'll need some...