Ed Hennis

Results 183 comments of Ed Hennis

> Missing tests or should add LCOV_EXCL_LINE @gregtatcam I have a task to add more test coverage. Most of those items can be tested, they just aren't yet.

@dangell7 I've addressed your comments. Could you re-review ASAP, so I can resolve the issue with unsigned commits, and get this thing merged?

Commit message: ``` Implement Lending Protocol (unsupported) (#5270) - Spec: XLS-66 - Introduces amendment "LendingProtocol", but leaves it UNSUPPORTED to allow for standalone testing, future development work, and potential bug...

@thejohnfreeman @vlntb I want to bring your attention to draft PR #5180. It builds on top of this PR, but adds three commits: 1. The MacOS CI jobs have 4...

Just brainstorming here, how about we handle the special case where the account creation hasn't been validated, we return `Sequence: 0`? We could potentially add a `TentativeSequence` outside of the...

This may be bike-shedding at this point, but I think the status name `failed` is going to cause confusion with people who don't read documentation. `feeClaimed` seems more intuitive to...

> The negative rate has different results across different operating systems. As far as I can tell, this is a unit test problem, and not a transaction engine problem. Specifically,...

> @Xtinc-T should this PR be closed? If it's still under development, it should be converted to a draft, which I'll do now. If that's incorrect, feel free to change...

> > 1. sleStatus_ is an optional. It should be a vector, in case more than one permissioned domain is affected > > modified and added check for size() >...