Ed Hennis

@thejohnfreeman I see this has two approvals. Since I've verified that it builds under Windows, it's up to you if you want to wait for mine, too, or go ahead...

This has been squashed and merged to https://github.com/ximinez/rippled/tree/ci/getledger

Also, since it seems this PR is still under active development, could you convert it to a draft?

I could make an argument that this is a display issue on the part of the explorers and/or wallets. This is a non-standard currency, which you pointed out. `rippled` is...

Outline of a solution: 1. New function `bool isBadCurrency(Currency)` that returns true if the only non-zero bytes are `0x58525`. 2. If the amendment is enabled, return `temBAD_CURRENCY` if `isBadCurrency` is...

> Regarding 4. [@ximinez](https://github.com/ximinez?rgh-link-date=2025-02-19T18%3A02%3A33.000Z), are you suggesting forbidding the creation (or setting) of `MPT` metadata to `0x58525`? Yes, but only if that's the _entire_ metadata. > MPTs might be trickier....

> I chose the allowed characters based on non-standard codes currently in use. Also, the 4 character minimum is necessary to avoid overlap with ISO-like currency codes including but not...

> It has to be _exactly_ 3 letters, not including fewer - standard currency codes are exactly 3 letters. > [xrpl.org/docs/references/protocol/data-types/currency-formats#standard-currency-codes](https://xrpl.org/docs/references/protocol/data-types/currency-formats#standard-currency-codes) Copying what I said [here](https://github.com/ripple/explorer/issues/1130#issuecomment-2672287985): > Yes, you are...

> But to this specific idea, firstly `0x58525` seems like an unlikely value on its own for MPT Metadata (so do we really need to check?). I could see a...

> > > The point is that there is a standards compliant way for someone to use a currency code of less than 3 characters, so IMHO we shouldn't allow...