Ed Hennis
Ed Hennis
> What is the scenario that is tested here? It's demonstrating two things: 1. That the `[validator_list_sites]` and `[validator_list_keys]` are independent. This was already true. 2. That if all the...
Since this PR has been sitting for so long, I'm thinking that it should be expanded to simply _always_ try to load the VL cache files on start up. There...
Unfortunately, this is not ready for prime time. I ran a simple test over the weekend, running this branch for some time, and running `develop` for some time. What the...
This is ready for review. I accidentally ran the original code in the test mentioned in my previous comment. When I ran it again over the last few days, it...
Commit message: ``` Reduce duplicate peer traffic for ledger data (#5126) - Drop duplicate outgoing TMGetLedger messages per peer - Allow a retry after 30s in case of peer or...
This PR is out of date. I'll open another one when I get it caught up.
@vvysokikh1 I took your two suggestions. Could you confirm your approval?
> There are build errors in the latest commit: > > /User/rippled/src/test/app/Loan_test.cpp:1816:25: error: use of undeclared identifier 'json' 1816 | createJson, json(sfCounterpartySignature, Json::objectValue)); | ^ /User/rippled/src/test/app/Loan_test.cpp:1829:25: error: use of undeclared...
I don't normally rewrite history on a non-draft PR, but the tip had a build error, and I want to provide a single commit as the resolution for the issue...
There are some test failures in the latest commit. That's because I added support for an extra command line option, and didn't update the corresponding tests in RPCCall. I'll have...