rippled icon indicating copy to clipboard operation
rippled copied to clipboard
verified publisher icon XRPLF

Update dilithium submodule to latest changes

Open Xtinc-T opened this issue 1 year ago • 3 comments

High Level Overview of Change

This change integrates the Dilithium library as a submodule within the external folder. It enhances the modularity of the API to support different types of Dilithium. The CMake configuration has been updated to utilize Dilithium alongside existing cryptographic libraries, and Dilithium2 has been added as a library in the conanfile.

Context of Change

The integration of Dilithium aims to improve the cryptographic capabilities of the project by providing modular support for various types of Dilithium. This change ensures that the project can leverage Dilithium in conjunction with other cryptographic libraries like secp256k1 and ed25519-donna.

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Refactor (non-breaking change that only restructures code)
  • [ ] Performance (increase or change in throughput and/or latency)
  • [ ] Tests (you added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation update
  • [ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • [ ] Release

API Impact

  • [x] Public API: New feature (new methods and/or new fields)
  • [ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • [ ] libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • [ ] Peer protocol change (must be backward compatible or bump the peer protocol version)

Xtinc-T avatar Sep 13 '24 14:09 Xtinc-T

Looks good so far I would make the PR into your own develop branch though or make this a draft as its not ready yet.

dangell7 avatar Sep 14 '24 16:09 dangell7

@dangell7 Yes youre right. It was by accident yesterday. I have created a fork of develop and created an upstream branch to push my changes.

Xtinc-T avatar Sep 14 '24 16:09 Xtinc-T

@dangell7 Yes youre right. It was by accident yesterday. I have created a fork of develop and created an upstream branch to push my changes.

@Xtinc-T should this PR be closed?

mvadari avatar Nov 07 '24 19:11 mvadari

@Xtinc-T should this PR be closed?

If it's still under development, it should be converted to a draft, which I'll do now. If that's incorrect, feel free to change it back.

ximinez avatar Jan 07 '25 17:01 ximinez