rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Proposed 2.4.0-b1

Open ximinez opened this issue 1 year ago • 1 comments

High Level Overview of Change

This is a beta for the 2.4.0 release.

Highlights:

  • #5042

The base branch is release. All releases (including betas) go in release. This PR will be merged with --ff-only (not squashed or rebased, and not using the GitHub UI) to both release and develop.

Context of Change

This introduces

  • Antithesis instrumentation, and a new model for writing (most) asserts.
  • A few unit test changes and additions.

Type of Change

  • [x] Release

API Impact

No API impact.

ximinez avatar Dec 03 '24 21:12 ximinez

Codecov Report

Attention: Patch coverage is 79.84145% with 178 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (f64cf91) to head (a2f5459).

Files with missing lines Patch % Lines
src/xrpld/overlay/detail/PeerImp.cpp 0.0% 15 Missing :warning:
src/libxrpl/json/json_value.cpp 40.0% 12 Missing :warning:
src/xrpld/app/ledger/detail/LedgerMaster.cpp 38.5% 8 Missing :warning:
src/xrpld/perflog/detail/PerfLogImp.cpp 0.0% 8 Missing :warning:
src/xrpld/app/misc/detail/ValidatorList.cpp 80.0% 5 Missing :warning:
src/xrpld/overlay/detail/OverlayImpl.cpp 37.5% 5 Missing :warning:
src/xrpld/peerfinder/detail/Logic.h 54.5% 5 Missing :warning:
src/libxrpl/basics/Log.cpp 0.0% 4 Missing :warning:
src/xrpld/app/main/Application.cpp 71.4% 4 Missing :warning:
src/xrpld/app/misc/NetworkOPs.cpp 76.5% 4 Missing :warning:
... and 73 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           release   #5212     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          784     784             
  Lines        66681   66681             
  Branches      8162    8138     -24     
=========================================
- Hits         51950   51939     -11     
- Misses       14731   14742     +11     
Files with missing lines Coverage Δ
include/xrpl/basics/Buffer.h 100.0% <100.0%> (ø)
include/xrpl/basics/SlabAllocator.h 94.6% <100.0%> (ø)
include/xrpl/basics/Slice.h 96.8% <100.0%> (ø)
include/xrpl/basics/partitioned_unordered_map.h 99.1% <100.0%> (ø)
include/xrpl/basics/random.h 100.0% <100.0%> (ø)
include/xrpl/basics/scope.h 100.0% <100.0%> (ø)
include/xrpl/basics/spinlock.h 93.5% <100.0%> (ø)
include/xrpl/beast/asio/io_latency_probe.h 96.8% <100.0%> (ø)
include/xrpl/beast/clock/manual_clock.h 100.0% <100.0%> (ø)
.../beast/container/detail/aged_unordered_container.h 96.5% <100.0%> (ø)
... and 234 more

... and 1 file with indirect coverage changes

Impacted file tree graph

codecov[bot] avatar Dec 03 '24 22:12 codecov[bot]

This PR is out of date. I'll open another one when I get it caught up.

ximinez avatar Dec 05 '24 23:12 ximinez