Jonathan LEI

Results 211 comments of Jonathan LEI

Rebased to keep branch from becoming staled.

As communicated separately, please feel free to go ahead and implement this if you have the time and interest :)

`starknet-rs` no longer controls this type. It now sources this type from `starknet-types-core`.

Thanks for reporting! Lemme look into this and work on a fix.

Hmmm wait a second. The `fe_utils` module is private and is not accessible by external crates. I can't make sense of the reproducer... how is it able to import that...

Thanks for the PR. However, `starknet-core/src/types/codegen.rs` is for RPC types, which is strictly derived from the specification and must not be manually edited. The RPC error type already contains a...

Interesting. Guess we will first need to implement [SNIP-12](https://github.com/starknet-io/SNIPs/blob/main/SNIPS/snip-12.md).

How are you parsing the class? IIRC the class as generated by the compiler will always have the `abi` field, even when it's empty. This type is for the compiler...

Looks like the switch to `raw_value` in https://github.com/xJonathanLEI/starknet-rs/commit/c5cf1967d44dd61fb68b36cefed710cc8518b1ab has made this worse. Previously only artifacts with values that can be converted to the scientific notation without precision loss are affected;...