Jonathan LEI

Results 214 comments of Jonathan LEI

While this implementation probably works, I'm really not a fan of adding `serde_json::Value` to a supposedly neutral trait of `Provider`. I mean it's probably acceptable to add it to `JsonRpcTransport`,...

TBH I don't think the `inner` part makes any difference. I could be wrong but I think a single field struct should be exactly equivalent to a newtype struct in...

`starknet-ff` was removed as part of #562. Closing this now as it's no longer relevant.

Running the benchmark on my machine the perf changes from this seems to be within noise threshold. I'm not sure about this. Need to test a bit more I guess.

@tcoratger This PR seems no longer relevant as the new `Felt` type does not provide methods equivalent to what you're adding here?

Also it will be superseded by anything that comes out of #608 anyways. Closing now.

In an ideal world there should probably just be one. However: 1. The sequencer-specific type exists because the sequencer apparently indeed returns more variants than what's seen on JSON-RPC. If...

As explained there doesn't seem to be an apparent clean solution. Closing this for now.