Jonathan LEI

Results 182 comments of Jonathan LEI

Hey @glihm thanks for the PR. I see you're modelling the types here directly after their Cairo implementations, with the internals exposed. It kinda makes me wonder though: do we...

Hi, I'm trying to implement [SNIP-12](https://github.com/starknet-io/SNIPs/blob/main/SNIPS/snip-12.md) in [`starknet-rs`](https://github.com/xJonathanLEI/starknet-rs). Given the lack of test vectors from the spec I decided to use `starknet.js` for generating test data, since it's pretty much...

Hey @thiagodeev I saw you committed to SNIP-12 so pinging you here. Any thoughts on this? Thanks!

It's worth noting that SNIP-12 actually [defines the encoded type to just be `merkletree`](https://github.com/starknet-io/SNIPs/blob/cde69c49dac39e77763afc0d4d06d971017991df/SNIPS/snip-12.md?plain=1#L225). Whether this is a bug in SNIP-12 itself is debatable, but honestly `starknet.js` is really just...

Hmm this is very weird and shouldn't happen. Would you be able to help debug this? Sorry for the long delay.

The weird part is that no changes regarding the installation pipeline has been made recently, but the issue resolved itself. So it seems to be something irrelevant to our setup...

ABI-based encoding/decoding is indeed one more the most important missing features in `starknet-rs`. Will prioritize this accordingly.

I just ran into this same issue. Was about to submit bug report and got here. The agent believes it's an empty file and just went crazy. Submitting a simple...

Thanks for reporting. This looks like an issue with the shell detection script. I will look into this.