Jonathan LEI
Jonathan LEI
It seems that #5 has made the library compile for `x86_64-pc-windows-gnu`. The only target left is `x86_64-pc-windows-msvc`.
Interesting! Will definitely look into it. However, for the `endian.h` part, as mentioned in #4, I actually removed that on purpose for all platforms for the sake of saving library...
Just tried using the PR branch to build with MSVC. No luck. I think right now the issue is mostly about the lack of 128-bit integer support. Maybe we can...
I just tried replacing `__int128_t` with `boost::multiprecision::uint128_t`, and most of the errors are now gone. I'm still having issue with `__builtin_clzll` though. Making progress.
Made some further changes and now it compiles on MSVC. FINALLY. However, one of the tests is failing. Not sure why: ```log warning: cl : Command line warning D9002 :...
Hi @gsnoff, thanks for reporting the issue, but have you considered using the alternative as recommended here? https://github.com/xJonathanLEI/starkware-crypto-rs#using-starknet-crypto-instead `starknet-crypto` implements the exact same crypto primitives, except in pure Rust and...
Sorry for pushing but would be nice if we can get this in :) Thanks!
The issue with `Iterator` is then you can't use say slices they yield `&FieldElement` instead of `FieldELement`.
What we _could_ do is maybe `T: AsRef`? This way you can send in anything that can be referenced as a slice, but then... if you can reference it as...
Oh the other hand, we can indeed provide a hasher type which would actually work better with iterators? Such a hasher would probably be rather generic and won't hash the...