Jonathan LEI

It's been... a while. While I agree that a mock transport would be helpful for testing stuff in downstream applications, I don't quite agree with the approach taken here. In...

Parsing function call return values (and also encoding calldata) is currently a missing feature of `starknet-rs` but is on the roadmap: https://github.com/xJonathanLEI/starknet-rs/blob/e3f3e4fdaf21011c3323201ac203db6654310324/README.md?plain=1#L38-L40 So unfortunately you'll probably have to implement customized...

Hey guys sorry for the late reply. I actually quite like the design of `ethabi` so I think that's a good approach. Lemme open a separate issue to track this...

@haroune-mohammedi That's great! I'm actually also working on supporting Cairo 1 artifact parsing (& class hash computation) so there _will_ be conflicts. It should be easy to resolve but here's...

Hi @adrienlacombe thanks for reporting. Is there any information on which specific commit in [LedgerHQ/app-starknet](https://github.com/LedgerHQ/app-starknet) is aiming to be released? I need to build from source to be able to...

Got it. Will just assume the latest commit for now.

Maybe use ChatGPT to help with this?

Thanks @omarespejel! I guess it's best to follow existing items that already have some docs. e.g. https://github.com/xJonathanLEI/starknet-rs/blob/f7cc49ea99aaccbfb2465fe8fb665bdff21da044/starknet-ff/src/lib.rs#L147-L156

Basic documentation now exists for all crates. The docs are by no means extensive. In most cases they're just basic description of what the type/method does, without giving code examples....

It kinda sounds like mostly a concern of `starknet_types_core` if it wouldn't change its public API? Assuming it will be implemented as a crate feature there, I guess we can...