Jonathan LEI

Results 179 comments of Jonathan LEI
trafficstars

Would love to see support for Android. For me the build error is `mman::shm_open` not being available for Android. My use case is to make the Solidity compiler portable across...

Thanks for the reply. So Apple basically killed fdb... The example code doesn't compile. For example: var location = await db.Directory.CreateOrOpenAsync("Test", cancel); This line is broken as `CreateOrOpenAsync()` doesn't accept...

Just ran their benchmark on my machine. Before ([b091cb8](https://github.com/eqlabs/pathfinder/tree/b091cb889e624897dbb0cbec3c1df9a9e411eb1e)): ```log pedersen_hash time: [3.1228 ms 3.1455 ms 3.1732 ms] ``` After ([3331f26](https://github.com/eqlabs/pathfinder/tree/3331f26598640822838e1a49857a8492038c5620)): ```log pedersen_hash time: [239.06 us 240.10 us 241.21 us]...

Just looked at the updated specs and it seems to deviate from the existing `pathfiner` implementation by a lot. Our JSON-RPC client would essentially become useless if we indeed adapt...

I think this will be best structured as: - an `AccountFactory` (as always, naming not final) trait; and - an additional feature-gated crate like `starknet-account-impls` that contains the actual account...

Intersting. I didn't know this before. Will implement soon. Thanks!

That would mean we need to make the method calls return some intermedia representation of the requests though, pretty much like we did with `Account::execute()`.

Thanks for that! I guess a downside of such batching is you'd lose strong typing, unless you only allow batching the same request type.

Yeah I mean then you have to do some kind of unwrap. Lemme have a think about how this can be best implemented. Will update this soon :)