Jonathan LEI

Results 182 comments of Jonathan LEI
trafficstars

The new universal deployer contract is a completely different implementation that uses Poseidon hash instead of Pedersen. So no, we should not change this. Whether we should support the new...

This is a known issue: https://github.com/xJonathanLEI/starknet-rs/blob/91425ad9c20cceaf87f5ae179341f7e1f7958507/starknet-crypto/src/fe_utils.rs#L43 I will keep this issue open in case someone wants to contribute to add a constant-time version alongside the existing one.

Hi sorry for the delay. I think it makes sense to allow construction of this type. I just want a bit more context on cases where this is useful. Care...

This is a known issue: https://github.com/xJonathanLEI/starknet-rs/blob/91425ad9c20cceaf87f5ae179341f7e1f7958507/starknet-crypto/src/fe_utils.rs#L43 I will keep this issue open in case someone wants to contribute to add a constant-time version alongside the existing one.

Thanks for reaching out and I'm glad you like the library :) Transaction watching isn't something that's built-in right now, and applications must implement their own watching logic. For example,...

I'm pretty sure you can indeed use the newly declared class in the same block as I believe I've done exactly that multiple times.

Likely a nonce issue. Maybe your account isn't setting to use `pending`. Or maybe the node you're querying against hasn't accounted for the `pending` state update. In fact, even if...

Oh btw this is probably not worth yanking and re-relasing. Sending this pretty much just as a heads up that downstream libs are being broken :)

@tcoratger Yes the codegen file should not be modified in any case, as any codegen update will overwrite all the changes. @aniketpr01 Please make changes to [xJonathanLEI/starknet-jsonrpc-codegen](https://github.com/xJonathanLEI/starknet-jsonrpc-codegen) such that the...