Jonathan LEI comments

Results 182 comments of


                                            Jonathan LEI

trafficstars

feat: allow formatter to format stdin

@spapinistarkware Helix seems to rely solely on treesitter for syntax highlighting so I can't tell. I haven't tried using the Cairo LSP with neovim tho.

dev: tree-sitter formal syntax definition?

I would argue they're for different use cases. Treesitter is a widely adopted format (iirc GitHub highlights sources using treesitter), and is very useful when the lsp isn't available (web,...

fix(formatter): incorrect exit code on files with syntax errors

Thanks for the reviews! Please let me know if anything is pending from my side.

fix(formatter): incorrect exit code on files with syntax errors

Ah I wasn't aware of that being a requirement. Rebased now :)

fix(formatter): incorrect exit code on files with syntax errors

Wait that's auto-merged? lol

fix(formatter): incorrect exit code on files with syntax errors

Yeah I thought the auto-merge were going through only if CI passes.

bug: files with syntax error incorrectly reported as well-formatted

For context, `cargo fmt` returns `1` if it encounters files with syntax errors.

dev: make binary target names cairo/starknet specific

A better approach is to just move all binary targets to a dedicated package called `cairo-cli`, like what's done in [`foundry`](https://github.com/foundry-rs/foundry): https://github.com/foundry-rs/foundry/blob/68714214c4aae6e337e6b2e40cf4de0d2de61f38/cli/Cargo.toml#L101_L109 (this makes installing all the binaries easy, but...

dev: make binary target names cairo/starknet specific

To demo how such a refactor would look like, I've created [a fork](https://github.com/xJonathanLEI/cairo) with the addition of a `cairo-cli` package containing all 7 CLI targets, in which you can just...

dev: make binary target names cairo/starknet specific

> What's more, this also applies to crate names. Yeah if we eventually want to put this on crates.io then crate names should also be made cairo/starknet-speicifc. Btw I've [squatted](https://crates.io/crates/cairo-cli)...