Jonathan LEI

Results 182 comments of Jonathan LEI

Update on the CRLF issue: after investigating more I realized it's not related to the CRLF handling logic itself. The project I encountered this issue on has a `.gitattributes` file:...

PR conflicts with `master` now due to `Cargo.lock`. I just rebased and squashed.

Rebased on `master` due to merge conflicts.

Rebased on `master` due to merge conflicts.

There are a few known issues on this PR base on my own usage: - the diff provider fails when `HEAD` does not exist (e.g. right after `git init`) -...

Hi @Byron thanks for the input! But I was under the impression that the _whole_ thing will be replaced by an upstream impl. aka I will just call something like...

Lol no worries. I think @pascalkuthe's plan is to leave the PR open until `gitoxide` has it. In that case, I'll just leave the PR as is cuz it's good...

Looks like the removal of file picker from #7264 has introduced some conflicts here.

Studied that PR a bit and conflict resolved. Git diff _plugin™_ works again.

Look I'm not obligated to resolve your comments, and I don't have time nor care enough to. As already stated in the convo above, there is currently no plan to...