Jonathan LEI

Results 211 comments of Jonathan LEI

@pascalkuthe OK I trimmed down my file quite a bit, and redacted everything so I can publish it here for everyone to see. It's not exactly "minimal", but it should...

BTW I tried the following Helix versions: - Current `master` (`8c9bb236`): no crash - PR head (`b7513220`): crash - PR rebased on `master`: crash

Great! Looking forward to the fix. For the key sequence, I actually noticed that sometimes I can trigger the crash by deleting chars. So I started looking for a continuous...

Reporting yet another problem, this time directly related to the PR. I'm not sure what the support status for Android is, but I've been using Helix on Android myself and...

Just high-lighting all the search result is not exactly the same as selecting all of them (and hence... highlighting) though. I would like to loop through all the matches, and...

That was quick! I will be testing this branch on my Cairo code too :)

Not sure if I did something wrong, but the highlighting doesn't seem to be the same before the update: Pre-0.10.0 highlight (with `hx` on `master`): ![image](https://user-images.githubusercontent.com/19556359/195791946-6c7dc89f-5556-477c-b8d4-927c96b6153d.png) Post-0.10.0 highlight of the...

OK this code snippet reproduced just that: ```cairo %lang starknet namespace Space { func initializer{syscall_ptr: felt*, pedersen_ptr: HashBuiltin*, range_check_ptr}( param_1: felt, param_2: felt, param_3: felt, param_4: felt ) { Proxy.initializer(param_1);...

Just tried and it works now! Will continue testing.

Looks like range calculation is off when the cursor is at the end of the buffer.