feat: adding support for HLB CantorMX F411
Description
Adding support for HLB CantorMX split version with BlackPill F411 8Mhz version. Project is open source with a 3DP case available.
Types of Changes
- [ ] Core
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement/optimization
- [X] Keyboard (addition or update)
- [ ] Keymap/layout (addition or update)
- [ ] Documentation
Checklist
- [X] My code follows the code style of this project: C, Python
- [X] I have read the PR Checklist document and have made the appropriate changes.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [X] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
The only difference provided by this firmware to the existing cantor firmware is the fact it configures a slightly different processor. Is there a reason once can't just change the development board entry to blackpill_f411 if they are using that? As I'm sure many people have already.
The only difference provided by this firmware to the existing cantor firmware is the fact it configures a slightly different processor. Is there a reason once can't just change the development board entry to
blackpill_f411if they are using that? As I'm sure many people have already.
With the original project it's the older F401 development board people still can purchase, moreover the cantor project is few years old and changing the original firmware to this blackpill version in particular F411 8Mhz crystal will just kill their split if they compile a new firmware. In my opinion it's not safe for all people using it to change the original project. You can also find an other version by 42keebs using a rp2040 mcu and slightly modified pcb so in all case we can't be united in a single firmware.
Finally this version of ours is linked to a free 3DP case I've designed with links to my GitHub and was purchased by few people during a private group buy.
Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.
Could it be reviewed for merging ?
Hello, I did all changes as requested even changing the last blockgin point that was readme.md to be "standard". Is it possible to accept my review request and move forward to merge ?
Hi would it be possible to resume review @fauxpark, all changes have been done months ago ? Why is it staling like that ?