adding at2 to atset keyboard

[anubhavd7]

Description

Types of Changes

• [ ] Core
• [ ] Bugfix
• [ ] New feature
• [ ] Enhancement/optimization
• [ x] Keyboard (addition or update)
• [ ] Keymap/layout/userspace (addition or update)
• [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

• [ ] My code follows the code style of this project: C, Python
• [ ] I have read the PR Checklist document and have made the appropriate changes.
• [ x] My change requires a change to the documentation.
• [ x] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [ x] I have added tests to cover my changes.
• [x ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[waffle87]

You address 2/7 of my comments. Please make the suggested changes/acknowledge you see the comments before re-requesting review.

[anubhavd7]

The via keymap also does not enable the VIA feature (VIA_ENABLE = yes). I presume this isn't what you intended..

sir please help me by telling me what changes i need to make via enable in my keymap

[waffle87]

sir please help me by telling me what changes i need to make via enable in my keymap

I practically told you what needs to be added. There is also documentation covering this, and thousands of examples within the repo. If this isn't something you're able to find, I believe the via keymap directory should be removed.

[anubhavd7]

sir please help me by telling me what changes i need to make via enable in my keymap

I practically told you what needs to be added. There is also documentation covering this, and thousands of examples within the repo. If this isn't something you're able to find, I believe the via keymap directory should be removed.

Done sir the changes has been made as per via

[waffle87]

Done sir the changes has been made as per via

I see no new changes at the time of replying to this. Also, please do not mark comments as resolved without addressing them. Further action like this is going to result in this PR closed.

[anubhavd7]

please review my keyboard i have made all the changes that were told to be made.

[fauxpark]

You still have not fixed the formatting on keyboard.json.

[anubhavd7]

Run qmk format-json -i on keyboard.json.

sir can you please help me, i am not able to understand how to run this code on a particular file.

[anubhavd7]

sir i have made all the changes that were asked to be made please review it.

[anubhavd7]

hello sir is there any other change that is needed?

[tzarc]

As previously specified there is no link to available hardware, either a purchase page or to CAD designs. Unless this is rectified this will not be merged.

[anubhavd7]

sir i have added purchase page link, you can check it and now it can be murged

[drashna]

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Aside from this, it LGTM

[anubhavd7]

@drashna sir i was asked to add via enable to merge my pr and now i am being asked to remove it. I have already uploaded the files in which via enable was not present you can even check it sir. I have done everything that was being asked to be done.

[zvecr]

Im guessing you chose to put forward this silly argument instead of reading what what actually put forward.

Please remove the via keymap.

I have added back the invalid label as this PR will not be accepted in its current form.

[anubhavd7]

i have removed via keymap sir

[anubhavd7]

please check it sir