qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

DD support for RP2040 bootloader options

Open waffle87 opened this issue 3 months ago • 5 comments

Description

Adds mappings to configure:

  • RP2040_BOOTLOADER_DOUBLE_TAP_RESET: rp2040_bootloader.double_tap_reset
  • RP2040_BOOTLOADER_DOUBLE_TAP_RESET_TIMEOUT: rp2040_bootloader.double_tap_reset_timeout
  • RP2040_BOOTLOADER_DOUBLE_TAP_RESET_LED: rp2040_bootloader.double_tap_reset_led

Switches to using UINT32_C() macro to type the value when it is used, rather than where it is defined.

Types of Changes

  • [x] Core
  • [x] Documentation

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87 avatar Sep 16 '25 18:09 waffle87

I feel like bootloader.rp2040.(options) would make more sense here, and be a bit more future proof. But implementing might be problematic

drashna avatar Sep 16 '25 20:09 drashna

I agree that might be more future proof, and qmk_lufa_bootloader could potentially be migrated under bootloader as well.

Will see what I can do, along with migrating existing keyboards and migration support in info.py.

waffle87 avatar Sep 16 '25 20:09 waffle87

Bootloader is already used, and isn't an object so can't be implemented that way.

zvecr avatar Sep 16 '25 20:09 zvecr

Bootloader is already used, and isn't an object so can't be implemented that way.

Yup, I figured as much. :/

bootloader_settings might work though?

drashna avatar Sep 17 '25 18:09 drashna

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Nov 07 '25 02:11 github-actions[bot]