Add Varys Keyboard

[vinaykomaravolu]

Description

Add Varys keyboard to QMK repo

Types of Changes

• [ ] Core
• [ ] Bugfix
• [ ] New feature
• [ ] Enhancement/optimization
• [x] Keyboard (addition or update)
• [ ] Keymap/layout/userspace (addition or update)
• [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

• [x] My code follows the code style of this project: C, Python
• [x] I have read the PR Checklist document and have made the appropriate changes.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[vinaykomaravolu]

Thank you for the comments. Will make the changes and resubmit.

[vinaykomaravolu]

Updated PR with drashna's comments

[vinaykomaravolu]

@waffle87 I thank you for the suggestions but I don't understand removing _MISC? I need to it work with my design with the OLED and with VIA. I also need it for how it will be used for the user experience side of things. I require 4 layers and _MISC for my changes, therefore I would like to leave them in.

[waffle87]

@waffle87 I thank you for the suggestions but I don't understand removing _MISC? I need to it work with my design with the OLED and with VIA. I also need it for how it will be used for the user experience side of things. I require 4 layers and _MISC for my changes, therefore I would like to leave them in.

Blank layers are discouraged. If you could find a use for it, that would be preferable.

[waffle87]

Please do not mark suggestions as resolved without addressing them. Eg. the suggestions regarding using the core tri layer feature...

[vinaykomaravolu]

@waffle87 I thank you for the suggestions but I don't understand removing _MISC? I need to it work with my design with the OLED and with VIA. I also need it for how it will be used for the user experience side of things. I require 4 layers and _MISC for my changes, therefore I would like to leave them in.

Blank layers are discouraged. If you could find a use for it, that would be preferable.

Understood, let me make these changes and resubmit.

[vinaykomaravolu]

Please do not mark suggestions as resolved without addressing them. Eg. the suggestions regarding using the core tri layer feature...

I apologize! I will try to be more aware going forward.

[vinaykomaravolu]

Addressed all the issues suggested by @waffle87

[vinaykomaravolu]

@drashna @waffle87 After your suggestions I went into a deep dive through the code to verify everything. After a couple of hours of debugging, VIA and the OLED would just not work with TRI_LAYER feature without the use of:

layer_state_t layer_state_set_user(layer_state_t state) { state = update_tri_layer_state(state, _RAISE, _LOWER, _MISC); return state; }

Not sure if its a bug or a specification with my board. However the most recent commit provides the exact configuration I want the keyboard to be in and works exactly as we intended.

If these changes are good to go, I'm happy with the merge.

[vinaykomaravolu]

@drashna @waffle87 Sorry for the ping. Any updates regarding this PR? Changes should be complete and good to go!