[Keyboard] Add PicoFX
Description
Adds support for the PicoFX keyboard, which is a specialized controller for the rhythm game Pump It Up. Three example keymaps are provided, including a default one with no special features.
Types of Changes
- [ ] Core
- [ ] Bugfix
- [ ] New feature
- [ ] Enhancement/optimization
- [x] Keyboard (addition or update)
- [x] Keymap/layout (addition or update)
- [ ] Documentation
Checklist
- [x] My code follows the code style of this project: C, Python
- [x] I have read the PR Checklist document and have made the appropriate changes.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).
Thank you very much for reviewing this PR. I've changed the matrix layout to match the physical keyboard layout as per the suggested edits, and applied qmk format-json as requested.
I'd like to leave the bootmagic bootloader shortcut in place, if that's acceptable, because it provides a useful fallback for entering the bootloader for users who haven't defined a QK_BOOT key in their keymap. Otherwise the keyboard has to be disassembled to access the button on the microcontroller, which is a hassle (as I've just been reminded, because I had the bootmagic key set wrong when I was testing the new matrix changes 😅). Would that be alright?
I'd like to leave the bootmagic bootloader shortcut in place, if that's acceptable, because it provides a useful fallback for entering the bootloader for users who haven't defined a
QK_BOOTkey in their keymap.
By default, bootmagic is triggered by holding the (0, 0) matrix position while plugging the keyboard in. This would be the top left key of this keyboard, now that the layout macro has been corrected.
You're welcome to define it as something else, however (0, 0) is the "standard", and is what many users will try after reading the docs, etc.
I believe this should be ready to go now 🙌
Thanks so much for the lighting support! I've integrated all suggested changes now 🙌
I believe this is all approved and ready to merge now. Would @waffle87 or @drashna be happy to do so?