qmk_firmware icon indicating copy to clipboard operation
qmk_firmware copied to clipboard

Add keymaps to momokai keyboards that switches debounce to asym_eager_defer_pk

Open peepeetee opened this issue 1 year ago • 8 comments

Description

This here pull request adds a keymap to each momokai keyboards that switches debounce to asym_eager_defer_pk

Types of Changes

  • [ ] Core
  • [ ] Bugfix
  • [ ] New feature
  • [x] Enhancement/optimization
  • [x] Keyboard (addition or update)
  • [ ] Keymap/layout/userspace (addition or update)
  • [ ] Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x] My code follows the code style of this project: C, Python
  • [x] I have read the PR Checklist document and have made the appropriate changes.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

peepeetee avatar Feb 28 '24 03:02 peepeetee

Keyboard updates must target develop.

waffle87 avatar Feb 28 '24 15:02 waffle87

Keyboard updates must target develop.

oh wow it's just changing the base branch I thought I would have to rebase it

peepeetee avatar Feb 28 '24 21:02 peepeetee

Keyboard updates must target develop.

I have decided to make this change with a new keymap instead, and the pull request should reflect that now. from what I recall this should be able to target master now? so I changed base branch back to master for now

peepeetee avatar Feb 29 '24 06:02 peepeetee

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar May 14 '24 01:05 github-actions[bot]

unstale

peepeetee avatar May 15 '24 21:05 peepeetee

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Jun 30 '24 01:06 github-actions[bot]

unstale agin

peepeetee avatar Jun 30 '24 03:06 peepeetee

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] avatar Aug 16 '24 01:08 github-actions[bot]

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]

github-actions[bot] avatar Sep 15 '24 02:09 github-actions[bot]