Vitaliy Potapov

Results 102 comments of Vitaliy Potapov

Hi! you should use ```js wsp.onMessage.addListener(evt => ...) ``` See: https://github.com/vitalets/websocket-as-promised#WebSocketAsPromised+onMessage

I'm wrapping links in [chatbase redirect](https://chatbase.com/documentation/taps) for tracking: ```js wrapUrl(url) { const redirUrl = new URL('https://chatbase.com/r'); redirUrl.searchParams.set('api_key', this._apiKey); redirUrl.searchParams.set('url', url); redirUrl.searchParams.set('platform', this._getPlatform()); redirUrl.searchParams.set('version', pkg.version); return redirUrl.toString(); } ```

I also don't see any special UI for messages with feedback flag. Looks like it's not implemented on UI side. I've just added intent `feedback`.

Is not this work? ``` js chrome.runtime.getURL.restore(); sinon.stub(chrome.runtime, "getURL", function (path) { return 'chrome-extension://' + chrome.runtime.id + '/' + path; }); ``` but anyway it also looks not obvious and...

I expect mount should not work as actually mouniting in that case is rendering in native thread.

As chromium revision in puppeteer is updated frequently I put `--deep` flag at the beginning of `codesign` command. So, after puppeteer update re-sign is very simple: ``` $ sudo codesign...

I confirm that @ajcrites's solution works, event with TypeScript. My `jest` config in `package.json` is following: ```json ... "transform": { "^.+\\.js$": "/node_modules/react-native/jest/preprocessor.js", "\\.(ts|tsx)$": "ts-jest" }, ... ```

@luckydonald thanks for suggestions! > It would still append it as new messages. I thought about reversed order, but there are two arguments against: 1. When you click to GitHub...

@luckydonald Do you mean something like this? --- Subscribe to this issue and stay notified about new [daily trending repos in Python](https://github.com/trending/python?since=daily)! [View latest comment](https://github.com/vitalets/github-trending-repos/issues/7#issuecomment-376014726) ---