Vitaliy Potapov

Results 102 comments of Vitaliy Potapov

Я тут еще размышлял над этим тикетом и понял в чем может быть сложность для frontend-first apps - в ттс. Если запрос пришел сразу на только фронт и я хочу...

I'm maintaining a [fork of webrtc-ips](https://github.com/vitalets/webrtc-ips) that currently works in Chrome 72 in my tests. It also supports [passing custom `urls` in params](https://github.com/vitalets/webrtc-ips/pull/1). Maybe it will help.

@dgozman thanks for the explanation! My use-case is for playwright-bdd project: after running all user-defined fixtures I always need to [attach some metadata](https://github.com/vitalets/playwright-bdd/blob/main/src/run/bddFixtures.ts#L102) to the testInfo. This is needed for...

> This is an interesting idea! Having a separate timeout would resolve concerns about running out of the time budget. I'll take a stab at implementing this. Looking forward for...

Ok, understood. I suggest the following improvements in the docs: 1. clarify how fixture timeout relates to the test timeout. E.g. if fixture timeout exceeds test timeout -> test timeout...

Fair enough, thanks for the idea! Will try to track attachments with onStepBegin/End. Just to clarify, in your example with parallel steps I will receive two `onStepBegin` events simultaneously and...

@pavelfeldman I've tried approach with mapping attachments in onStepBegin/End. It works fine with regular Playwright run, but breaks on merge-reports. When running merge-reports `result.attachments` is empty in every `onStepEnd` and...

> The way Playwright works, this solution will require putting all tests in describe blocks if multiple tests will have different tags in the spec file. It will be a...

This is how I'm mapping sources for `test.step()` calls in playwright-bdd. Use private method `testInfo._runAsStep` where you can pass custom location: ```ts const location = { file: '/path/to/sample.feature', line: 4,...