Thomas S. Binns

Results 108 comments of Thomas S. Binns

I definitely get that depending on facecolor the legibility of the colourmap changes, e.g., with the hot cmap those very strong values could become difficult to see with a white...

> Asked this question on Stackoverflow, maybe there is a generic way to customize a default colormap instead of building one from scratch Cool, would be interested to see. I...

> I think it would be too strict to always force the center of a two-slope colormap to be the same as the facecolor. Seems like a nice clear docs...

So @JohannesWiesner, is this something you are able to create a PR for at this time? Or is there also some help we can offer?

> I don't have time for this at the moment, but maybe over the Christmas holidays. There's no rush from our end. Unfortunately I would also not have time to...

Hi Johannes, I don't have the authority to say yes or no to this (would need @larsoner , @drammock, or @adam2392 for that), but just to explore what you're thinking...

Hmm, building docs is failing here on the new example (fine for me locally), but doesn't give a reason beyond ``` make: *** [Makefile:56: html] Killed Exited with code exit...

Okay, even using 1/4 the CPU count ends up using too much memory (find it surprising with 36 cores and 70 GB). Just reverting to a single job and taking...

Switching CI back to upstream since https://github.com/mne-tools/mne-python/pull/12747 was merged.

Wanted to make sure everything was green before submitting final GSoC stuff. Newly failing tests addressed in #228