Thomas S. Binns

> Hi @tsbinns , I've addressed your latest feedback. The implementation now follows the pattern you suggested. Ready for review! Looks good!

Hi @GioMarraffini, just FYI, Dan is away this week so won't be able to give feedback. Regarding the earlier discussion about BADs being included in the computation, I addressed this...

Hi @GioMarraffini, I am in the middle of double checking the bad channel handling behaviour, which I will (really) try and finish this week, but I would push any needed...

@GioMarraffini One comment looking at the example, what would the interpretation be of negative values? There are some occurring in the simulated data.

To summarise those changes pushed in [e93edca](https://github.com/mne-tools/mne-connectivity/pull/307/commits/e93edca4e84e5deaeec9474eb9d0b504816f5208): - Before, if `indices=None`, all-to-all connectivity would be computed, the connectivity values were stored as a (connections, ) array corresponding to the lower-triangular...

@GioMarraffini Thanks for the detailed answer! That makes sense. I think it would be good to include a short note about that in the example, perhaps after the results are...

@Laouen @GioMarraffini We can arrange a call to go through the PR together. The best time would be during [MNE's Office Hours](https://mne.discourse.group/t/mne-office-hours-on-discord/7439) held every other Friday. @drammock would be there,...

Hey @Laouen @GioMarraffini, we are around at the moment in the office hours. Feel free to drop by anytime until the end of the hour.