Thomas S. Binns
Thomas S. Binns
Sure, happy to look into this!
@adam2392 Sorry for the delay, I was on holiday the last 2 weeks. Yes, I would be very interested!
@adam2392 I'm happy to help out if the offer still stands!
Sounds good, I will try and get this done ASAP. Though it might be worth waiting until #184 is merged since this has some nice efficiency improvements and is unrelated...
WIP in #195
@adam2392 One of the steps mentioned in the wiki is uploading to and checking install from test-pypi, but I don't have access. Do you need to do this before moving...
Congrats @adam2392! > @tsbinns if you want to learn how to do CI stuff feel free to open a PR to get the ball rolling. I can do the (pretty...
@larsoner Do you want me to create a new maint/0.7 branch and update the built docs in the gh-pages branch?
@larsoner, of course, I understand. Canonical coherence is something myself and a number of other people in my group would definitely find useful, hence why we already started looking into...
I don't see any problems. With #163 merged `spectral_connectivity_time` can return complex values, would just need to list the new `cohy` method here alongside `cacoh`: https://github.com/mne-tools/mne-connectivity/blob/2af1398e7784350ec8f38c71061668e677fa27c0/mne_connectivity/spectral/time.py#L563-L569