Thomas S. Binns

icon indicating a website link tsbinns.com icon indicating an email [email protected]

icon company Intern, Sony Computer Science Laboratories icon location Tokyo, Japan icon location Neurotechnology @ Sony Computer Science Labs | PhD Neuroscience Fellow | OSS Developer

Results 108 comments of Thomas S. Binns

[GSOC] Add surrogate data generation for significant connectivity estimation

Thanks for the review @adam2392! Very good points, will have a look at implementing them by the end of the week. Cheers!

[GSOC] Add surrogate data generation for significant connectivity estimation

Comments should be addressed now @adam2392.

[GSOC] Add surrogate data generation for significant connectivity estimation

Hi @adam2392 & @larsoner, is there something you think is still missing from this I should be working on? I have some time this month if so.

[GSOC] Add surrogate data generation for significant connectivity estimation

Awesome! Thanks @larsoner 🚀

[MRG] ENH: Add weighted symbolic mutual information (wSMI) connectivity measure

@GioMarraffini @Laouen Thanks both for responding to my initial suggestion so quickly. The changes with the anti-aliasing parameter look very reasonable. Unfortunately the next 2 weeks at work are super...

[MRG] ENH: Add weighted symbolic mutual information (wSMI) connectivity measure

Rerunning the failing test; should not be a problem from your end.

[MRG] ENH: Add weighted symbolic mutual information (wSMI) connectivity measure

Something I also didn't consider before is the size of the testing data. The existing test data is 0.9 MB, but the wSMI data is 5.3 MB. Without the wSMI...

[MRG] ENH: Add weighted symbolic mutual information (wSMI) connectivity measure

> The problem with generating test data online is that we have no ground thruth for that data. Currently, the ground truth is the value obtained by the original function....

[MRG] ENH: Add weighted symbolic mutual information (wSMI) connectivity measure

Hi @GioMarraffini, do you think those latest commits in a8d826350fb34c56acdff57acb5056d8cb355707 are ready for another round of reviews?

[MRG] ENH: Add weighted symbolic mutual information (wSMI) connectivity measure

@larsoner and @drammock, please can I ask one of you to check through this. All previous comments pending these very minor recent ones have been addressed. The new function is...