Thomas S. Binns

This is what I get with the code you modified (again, blue is existing method; red is suggested method):  The additional independent shuffling for each epoch definitely helps. While...

Hi, thanks for your post! Definitely time domain Granger causality is useful to have. If you don't need it to be multivariate, you should be able to compute time domain...

Fixed in #12827

Hi @seqasim, thanks for the PR and sorry for not getting back to you sooner on this. I have a few comments/suggestions which I'll post below, but it's a really...

Just need to make sure that the new `cohy` method is described in the docstring for `spectral_connectivity_time()`: https://github.com/mne-tools/mne-connectivity/blob/ef0a4842d70ff784cbb3b913fc46033f25710ea2/mne_connectivity/spectral/time.py#L72-L75 And also an equation entry like for `coh`: https://github.com/mne-tools/mne-connectivity/blob/ef0a4842d70ff784cbb3b913fc46033f25710ea2/mne_connectivity/spectral/time.py#L245-L256

A more general comment for the new `phase_slope_index_time`: Even if we are not averaging over epochs in the call to `spectral_connectivity_time()`, do you think it makes sense to add an...

> But if not, I'm happy to pick it up with all your helpful comments later in the year. Yeah sounds good, there's no rush!

Thanks for the changes @seqasim! I am quite busy at the moment, but I will try to do another round of reviews soon. Looking at the CI logs, seems like...

Would also need to be sure to update `CITATION.cff` info (#229)

Also updated the docstring for `Annotations.orig_time` and added a `RuntimeWarning` when a string is provided but it gets converted to `None`. Thoughts on this?