Thomas S. Binns

Results 108 comments of Thomas S. Binns

Okay, so if I understand correctly, you'd recommend an option to switch from one `multi-img` to multiple `single-img`. So I should focus on something like point 2 and leave 1...

Had some time to look into this and was hoping to get some advice: From what I see, `multi-img`s get created in `matplotlib_scraper()` (L212-215): https://github.com/sphinx-gallery/sphinx-gallery/blob/a3a8de1034839a164d8da0eb057e4a9612ec3ab2/sphinx_gallery/scrapers.py#L209-L219 My first thought was to...

Ah sorry, I just checked again and there was something I had overlooked, so you're right, passing `file_conf` works fine. If people are happy for `file_conf` to be passed through...

Yes, sorry, thought I had closed this already!

Have now added support for `EpochsTFR` to `spectral_connectivity_time` (using a custom MNE branch with the bug in #12831 fixed).

Resetting tests to main mne branch now that https://github.com/mne-tools/mne-python/pull/12842 is merged

Thanks for the detailed review @drammock! Until those wider API questions are addressed I'll double check the unit tests and try to find where the deviation in Fourier/Welch pipelines.

Conda test keeps freezing on the micromamba setup step, seems similar to this: https://github.com/mamba-org/setup-micromamba/issues/225 Is it worth trying to fix now?

Haven't forgotten about this, just need to sort https://github.com/mne-tools/mne-python/pull/12910 before I can finalise the changes and tests here.

https://github.com/mne-tools/mne-python/pull/12910 is now merged, so I can fix the outstanding issues here.