Thomas S. Binns
Thomas S. Binns
I've addressed the previous issues. There should now be full support for `EpochsSpectrum` and `EpochsTFR` data in `spectral_connectivity_epochs` (including time-resolved multitaper coeffs) and for `EpochsTFR` in `spectral_connectivity_time`, along with unit...
Given that the multitaper TFR requires the unreleased MNE 1.10, is it worth holding off on merging (once it's checked and ready to go) until after MNE-Conn 0.8 is released?...
> You could, but even then you'll need to add a version guard to the mne-connectivity that checks the MNE version. You have them in tests but you also need...
> Is the issue just about which MNE version is currently installed? Or is it to do with which version of MNE the data were saved to disk with? Moreso...
Thanks @drammock and @larsoner for the patience with this!
Sorry for the delay on this, had some trouble getting the old code working, so I definitely agree with @Laouen that this existing public implementation is not so practical to...
Hi @Laouen, a PR would be welcome on this! I would suggest wSMI is implemented as a new [connectivity function](https://mne.tools/mne-connectivity/dev/api.html#connectivity-functions) like [`envelope_correlation()`](https://mne.tools/mne-connectivity/dev/generated/mne_connectivity.envelope_correlation.html#mne_connectivity.envelope_correlation) or [`phase_slope_index()`](https://mne.tools/mne-connectivity/dev/generated/mne_connectivity.phase_slope_index.html). MNE has a lot of useful...
Plotting connectivity matrices with both negative and positive values should change default colorbar
There is precedent with things like [`plot_evoked_topomap`](https://mne.tools/stable/generated/mne.viz.plot_evoked_topomap.html) in the main package for having the default colourmap adjust to the values: > ```If None, 'Reds' is used for data that is...
Plotting connectivity matrices with both negative and positive values should change default colorbar
@JohannesWiesner Would you be able to open a PR for this?
Plotting connectivity matrices with both negative and positive values should change default colorbar
> 1.) I think it would be good if the value 0 always is the same as the "facecolor" argument, so that connections with the value 0 blend in with...