Tim te Beek

Results 1243 comments of Tim te Beek

This is an interesting case: we first and separate evaluate a precondition to determine if we need further changes; that precondition resolves to true due to the presence of `com.sun.net.ssl.HostnameVerifier`;...

I think you're correct in expecting such cases to be handled by `org.openrewrite.gradle.ChangeDependency`; I'd consider that something not yet implemented. You're welcome to help explore a fix, perhaps starting with...

Ideally tackled by calling out to the dedicated recipe in - https://github.com/openrewrite/rewrite/issues/2737 - https://github.com/openrewrite/rewrite/pull/3613 Through something like ```java doAfterVisit(new RemoveEmptyXmlTags().getVisitor()); ```

Indeed that's tackled since! Thanks for helping clear out the backlog. 🙏

Thanks for the work here @dpozinen ! I'll review after I come back home Sunday. Also, it seems like the automated suggestions broke compilation after being applied ``` > Task...

I only just now see you had logged an issue along those exact lines; thanks again! It's not always easy to keep up. :) - https://github.com/openrewrite/rewrite/issues/4246

Great to see this replicated, thanks! Did you already step through using this test as well?

Ah thanks a lot for logging the issue before logging off; enjoy your time off! We'll see if some of the usual suspects gets to it before you return. ;)

Thanks for the continued work on this @vudayani ! I must say it's great to see this come in, also taking into account the out-of-bounds-delivered raw feedback. :) I've fixed...

Thanks for the continued work on this @vudayani ! We're on to a downstream failure right now it seems. `class org.openrewrite.java.tree.J$Erroneous cannot be cast to class org.openrewrite.java.tree.Expression` in `org.openrewrite.java.format.SpacesVisitor`. ```...